Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bootstrap engine 1.21 #4314

Merged

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Oct 22, 2021

Proposed Changes

Types of Changes

Verification

Linked Issues

User-Facing Change


Further Comments

@briandowns briandowns requested a review from a team October 22, 2021 23:37
@briandowns briandowns self-assigned this Oct 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #4314 (4ffb406) into engine-1.21 (50bcc9a) will decrease coverage by 0.19%.
The diff coverage is 8.78%.

Impacted file tree graph

@@               Coverage Diff               @@
##           engine-1.21    #4314      +/-   ##
===============================================
- Coverage        11.49%   11.29%   -0.20%     
===============================================
  Files              139      139              
  Lines             9025     9177     +152     
===============================================
  Hits              1037     1037              
- Misses            7763     7915     +152     
  Partials           225      225              
Flag Coverage Δ
inttests 0.66% <0.00%> (-0.02%) ⬇️
unittests 10.96% <8.78%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cli/server/server.go 0.00% <0.00%> (ø)
pkg/clientaccess/kubeconfig.go 0.00% <ø> (ø)
pkg/cluster/bootstrap.go 0.00% <0.00%> (ø)
pkg/cluster/cluster.go 0.00% <0.00%> (ø)
pkg/cluster/storage.go 0.00% <0.00%> (ø)
pkg/daemons/control/deps/deps.go 44.32% <ø> (ø)
pkg/daemons/control/server.go 0.00% <0.00%> (ø)
pkg/etcd/etcd.go 16.88% <0.00%> (ø)
pkg/bootstrap/bootstrap.go 20.51% <16.66%> (-3.02%) ⬇️
pkg/clientaccess/token.go 89.83% <88.23%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bcc9a...4ffb406. Read the comment docs.

@briandowns briandowns merged commit 45c5d78 into k3s-io:engine-1.21 Oct 25, 2021
brandond added a commit to brandond/k3s that referenced this pull request Oct 27, 2021
This reverts commits
c5a9154
45c5d78

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit that referenced this pull request Oct 27, 2021
This reverts commits
c5a9154
45c5d78

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants