Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Docker test on Github Actions arm64 runners #11705

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Run Docker test on Github Actions arm64 runners #11705

merged 4 commits into from
Feb 4, 2025

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 3, 2025 •
edited
Loading

Proposed Changes

  • Build both arm64 and amd64 versions of k3s artifacts in GHA
  • Implement Docker Go Tests as a matrix of both Arm64 and Amd64 architectures.
  • Consolidate Drone tests down to only be PR for arm (32bit) and tagging events (for publishing).
  • Reduce failures for Skew and Upgrade tests on forks by moving away from git branch to a channel based flag (git history is too inconsistent on GHA runners and just source ./script/version.sh is easier)

Types of Changes

Testing Overhaul

Verification

CI is green
THIS ALL RUNS IN 5m 38s
image

Testing

Its all testing

Linked Issues

#11704

User-Facing Change

Further Comments

@dereknola dereknola requested a review from a team as a code owner February 3, 2025 17:33
@dereknola
Build and Run Arm64 Docker Tests
652ee24 
Compile go tests for both amd64 and arm64

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Use version.sh to determine channel, not git
976a110 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Consolidate docker tests into 2D matrix
aaffd29 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
Remove old Docker test from Drone and Github Actions
2826094 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (f78769d) to head (2826094).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11705      +/-   ##
==========================================
- Coverage   49.89%   47.61%   -2.29%     
==========================================
  Files         185      185              
  Lines       19353    19353              
==========================================
- Hits         9656     9214     -442     
- Misses       8300     8804     +504     
+ Partials     1397     1335      -62
Flag Coverage Δ
e2etests 40.33% <ø> (-3.80%) ⬇️
inttests 35.00% <ø> (-0.06%) ⬇️
unittests 17.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 1666b5c into k3s-io:master Feb 4, 2025
45 of 46 checks passed
@dereknola dereknola deleted the arm64_builds branch February 7, 2025 17:04
dereknola added a commit to dereknola/k3s that referenced this pull request Feb 7, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (k3s-io#11705)
ea633eb 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Feb 7, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (k3s-io#11705)
f49cd98 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Feb 7, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (k3s-io#11705)
e86fb74 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Feb 7, 2025
Merged
Merged
Merged
dereknola added a commit to dereknola/k3s that referenced this pull request Feb 7, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (k3s-io#11705)
046c0be 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola mentioned this pull request Feb 7, 2025
Merged
dereknola added a commit that referenced this pull request Feb 7, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (#11705)
9e2dd07 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Feb 8, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (#11705)
a5edf2b 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Feb 8, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (#11705)
a2f6657 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Feb 8, 2025
@dereknola
Run Docker test on Github Actions arm64 runners (#11705)
2b7476a 
* Build and Run Arm64 Docker Tests
* Compile go tests for both amd64 and arm64
* Use version.sh to determine channel, not git
* Consolidate docker tests into 2D matrix
* Remove old Docker test from Drone and Github Actions

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@vitorsavian vitorsavian vitorsavian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @vitorsavian