Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use bridge as the default networking mode #986

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: Use bridge as the default networking mode #986

merged 1 commit into from
Mar 15, 2022

Conversation

serverwentdown
Copy link
Contributor

@serverwentdown serverwentdown commented Feb 23, 2022 •
edited
Loading

Improves compatibility with rootless Podman

What

Sets the default NetworkMode to bridge.

Why

  • Some users might like to use k3d with Podman (See [FEATURE] Podman support #84)
  • Podman currently defaults to slirp4netns when running as a rootless service.
    • Changing this default behaviour in Podman might break other users of the Podman API.

Implications

  • Might break usage with runtimes without support for bridge networks (Is this a thing?)

@serverwentdown
fix: Use bridge as the default networking mode
b88e1d3 
Improves compatibility with rootless Podman
@serverwentdown serverwentdown mentioned this pull request Feb 23, 2022
Closed
@serverwentdown
Copy link
Contributor Author

serverwentdown commented Feb 23, 2022 •
edited
Loading

To try this out, build and run as non-root:

systemctl --user start podman.socket
export DOCKER_HOST=unix://$XDG_RUNTIME_DIR/podman/podman.sock
k3d cluster create

@serverwentdown serverwentdown changed the title fix: Use bridge as the default networking mode [Enhancement] Use bridge as the default networking mode Feb 23, 2022
@serverwentdown serverwentdown changed the title [Enhancement] Use bridge as the default networking mode fix: Use bridge as the default networking mode Feb 23, 2022
@serverwentdown serverwentdown mentioned this pull request Feb 23, 2022
Merged
@iwilltry42 iwilltry42 added this to the v5.4.0 milestone Mar 15, 2022
@iwilltry42 iwilltry42 added the enhancement New feature or request label Mar 15, 2022
@iwilltry42 iwilltry42 self-requested a review March 15, 2022 11:29
iwilltry42
iwilltry42 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwilltry42 iwilltry42 merged commit bf01eb0 into k3d-io:main Mar 15, 2022
@iwilltry42
Copy link
Member

Thank you @serverwentdown , much appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@serverwentdown @iwilltry42