fix: DOCKER_HOST handling of unix sockets
#1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverwentdown
changed the title
DOCKER_HOST handling of unix sockets
In a580edb, GetHost() introduced code to handle the DfD use case. However, it also caused "unix:///" DOCKER_HOST values to be parsed incorrectly. This resulted in kubeconfigs containing "unix" as the hostname. This patch ensures all "unix:///" DOCKER_HOST values are parsed as an empty host (and thus set as 0.0.0.0 in kubeconfig)
serverwentdown
force-pushed
the
fix-docker-host-handling-on-unix-sockets
branch
from
d915ae6
to
0c1c641
Compare
Closed
iwilltry42
approved these changes
May 13, 2022
|
Thank you @serverwentdown ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a580edb, GetHost() introduced code to handle the DfD use case. However, it also caused "unix:///" DOCKER_HOST values to be parsed incorrectly. This resulted in kubeconfigs containing "unix" as the hostname.
This patch ensures all "unix:///" DOCKER_HOST values are parsed as an empty host (and thus set as 0.0.0.0 in kubeconfig)