build with kaldi-native-fbank having dithering

k2-fsa · Mar 20, 2024 · 5afda1e · 5afda1e
1 parent 4f04fb8
commit 5afda1e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/cmake/kaldi-native-fbank.cmake b/cmake/kaldi-native-fbank.cmake
@@ -1,10 +1,9 @@
 function(download_kaldi_native_fbank)
   include(FetchContent)
 
-  # TODO: update is required, so that dithering works... (it was missing)
-  set(kaldi_native_fbank_URL  "https://github.com/csukuangfj/kaldi-native-fbank/archive/refs/tags/v1.18.7.tar.gz")
-  set(kaldi_native_fbank_URL2 "https://huggingface.co/csukuangfj/sherpa-onnx-cmake-deps/resolve/main/kaldi-native-fbank-1.18.7.tar.gz")
-  set(kaldi_native_fbank_HASH "SHA256=e78fd9d481d83d7d6d1be0012752e6531cb614e030558a3491e3c033cb8e0e4e")
+  set(kaldi_native_fbank_URL  "https://github.com/csukuangfj/kaldi-native-fbank/archive/refs/tags/v1.19.1.tar.gz")
+  set(kaldi_native_fbank_URL2 "https://huggingface.co/csukuangfj/sherpa-onnx-cmake-deps/resolve/main/kaldi-native-fbank-1.19.1.tar.gz")
+  set(kaldi_native_fbank_HASH "SHA256=0cae8cbb9ea42916b214e088912f9e8f2f648f54756b305f93f552382f31f904")
 
   set(KALDI_NATIVE_FBANK_BUILD_TESTS OFF CACHE BOOL "" FORCE)
   set(KALDI_NATIVE_FBANK_BUILD_PYTHON OFF CACHE BOOL "" FORCE)

diff --git a/sherpa-onnx/csrc/features.h b/sherpa-onnx/csrc/features.h
@@ -37,8 +37,8 @@ struct FeatureExtractorConfig {
   // dithering constant, useful for signals with hard-zeroes in non-speech parts
   // this prevents large negative values in log-mel filterbanks
   //
-  // In k2, audio samples are in range [-1..+1], in kaldi the range was [-32k..+32k],
-  // so the value 0.00003 is equivalent to kaldi default 1.0
+  // In k2, audio samples are in range [-1..+1], in kaldi the range was
+  // [-32k..+32k], so the value 0.00003 is equivalent to kaldi default 1.0
   //
   float dither = 0.0f;  // dithering disabled by default