Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metadata for custom metrics #270

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Support metadata for custom metrics #270

merged 3 commits into from
Sep 23, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 23, 2023

No description provided.

@k1LoW k1LoW added the enhancement New feature or request label Sep 23, 2023
@k1LoW k1LoW self-assigned this Sep 23, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Code Metrics Report

main (bd079c7) #270 (09de623) +/-
Coverage 66.0% 66.6% +0.6%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Test Execution Time 26s 16s -10s
Details
  |                     | main (bd079c7) | #270 (09de623) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          66.0% |          66.6% | +0.6% |
  |   Files             |             31 |             31 |     0 |
  |   Lines             |           2752 |           2799 |   +47 |
+ |   Covered           |           1815 |           1863 |   +48 |
+ | Code to Test Ratio  |          1:0.5 |          1:0.5 |  +0.0 |
  |   Code              |           7146 |           7214 |   +68 |
+ |   Test              |           3367 |           3512 |  +145 |
+ | Test Execution Time |            26s |            16s |  -10s |

Code coverage of files in pull request scope (84.9% → 89.2%)

Files Coverage +/-
report/custom.go 89.2% +4.3%

Benchmark-0 (this is custom metrics test)

main (bd079c7) #270 (09de623) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 676.5 ns/op 676.5 ns/op 0.0 ns/op
Metadata
GOOS GOARCH
darwin amd64

Benchmark-1 (this is custom metrics test)

main (bd079c7) #270 (09de623) +/-
Number of iterations 1500 1500 0
Nanoseconds per iteration 1345 ns/op 1345 ns/op 0 ns/op
Metadata
GOOS GOARCH
darwin amd64

Reported by octocov

@k1LoW k1LoW merged commit 84fd096 into main Sep 23, 2023
@k1LoW k1LoW deleted the metadata branch September 23, 2023 05:18
@k1LoW k1LoW added the minor label Sep 23, 2023
@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant