Make controller-gen targets non .PHONY #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanluisvaladas
requested review from
ncopa and
jnummelin
and removed request for
a team
|
Initially I only planned to make controller-gen targets non .PHONY but while I was at it I found a few more things I didn't like and by now the PR is modifying more things than it should. I'll stop for now and once this is merged I'll continue fixing more things that aren't OK because otherwise it will get dififcult to merge... |
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
make generate and make manifests now don't need to be regenerated on every execution. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
This will cleanup files if anything goes wrong in their target. Taken from k0s#3046 Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
mikhail-sakhnov
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot to be made as part of #43 but this is what we can do so far without modifying the kustomize targets.
Kustomize recently moved from 4.5 to 5.0 so I'm merging only this for now which is only a small improvement and we can't improve anything else without handling this first.