Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysprobe and some docs for required mount/umount #3409

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jnummelin
Copy link
Member

Added sysprobe for detecting mount/umount being in PATH.

Also added some docs around the hard dependency.

Fixes #3386

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fixes k0sproject#3386

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin requested a review from a team as a code owner August 23, 2023 12:40
@jnummelin jnummelin merged commit d46b5e0 into k0sproject:main Aug 24, 2023
@jnummelin jnummelin deleted the docs/mount branch August 24, 2023 08:57
@twz123 twz123 mentioned this pull request Oct 25, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K0s workers require the mount binary to be in their PATH
2 participants