Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some new sysinfo probes #1784

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Some new sysinfo probes #1784

merged 1 commit into from
Jun 7, 2022

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 1, 2022

Description

  • /proc file system mounted
  • Executable in path: modprobe
  • $(ulimit -n) -ge 65536

xref #1581

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Some new sysinfo probes
0f474b8 
* /proc file system mounted
* Executable in path: modprobe
* $(ulimit -n) -ge 65536

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review June 1, 2022 14:44
@twz123 twz123 requested a review from a team as a code owner June 1, 2022 14:44
@twz123 twz123 requested a review from ncopa June 2, 2022 12:46
@twz123 twz123 merged commit 461641d into k0sproject:main Jun 7, 2022
@twz123 twz123 deleted the new-sysinfo-probes branch June 7, 2022 11:38
@twz123 twz123 mentioned this pull request Oct 25, 2023
Merged
16 tasks
@k0s-bot k0s-bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@mikhail-sakhnov mikhail-sakhnov Awaiting requested review from mikhail-sakhnov mikhail-sakhnov is a code owner automatically assigned from k0sproject/k0s-maintainers

@ncopa ncopa Awaiting requested review from ncopa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin