Use GitHub API to list images #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous solution required a full checkout of the repo in order to determine which images had changed. There was a subtle bug in there, as the checkout was not done with full depth. Only the most recent commit was fetched. This led to situations where the image list generation failed with "bad object" errors. There's a more straightforward approach using the GitHub API and the gh CLI. It allows for easy fetching of diffs and massaging them via jq queries. The same can be done to get the file list of a repository, eliminating the need for a checkout in both cases. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution required a full checkout of the repo in order to determine which images had changed. There was a subtle bug in there, as the checkout was not done with full depth. Only the most recent commit was fetched. This led to situations where the image list generation failed with "bad object" errors.
There's a more straightforward approach using the GitHub API and the gh CLI. It allows for easy fetching of diffs and massaging them via jq queries. The same can be done to get the file list of a repository, eliminating the need for a checkout in both cases.