Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg/errors with standard library functions #69

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 19, 2023

No description provided.

@twz123
Copy link
Member Author

twz123 commented Dec 19, 2023

The copyright check seems to fail when it shouldn't? 🤔

pkg/cluster/cluster.go: Warning: a newly introduced file contains an old copyright
pkg/cluster/key_store.go: Warning: a newly introduced file contains an old copyright
pkg/cluster/machine.go: Warning: a newly introduced file contains an old copyright
pkg/exec/local.go: Missing SPDX license identifier
pkg/exec/local.go: Missing or incorrect copyright boilerplate
gh: Not Found (HTTP 404)
{"message":"Not Found","documentation_url":"https://docs.github.com/rest"}Failed to add a github annotation to file: pkg/exec/local.go
* 1 files are missing or have incorrect copyright boilerplate

@kke
Copy link
Contributor

kke commented Dec 19, 2023

For the first few, I guess it lost track of file history somehow, but those are just Warnings.

pkg/exec/local.go: Missing or incorrect copyright boilerplate The boilerplate checker script .github/scripts/check_boilerplate.sh only ignores the kubernetes authors header in pkg/docker. I don't know why it didn't complain before.

@twz123
Copy link
Member Author

twz123 commented Dec 19, 2023

Maybe something like #74 might help?

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the replace-pkg-errors branch from 648da95 to ddd3a89 Compare December 20, 2023 08:48
@twz123 twz123 merged commit 119fb41 into k0sproject:main Dec 20, 2023
15 checks passed
@twz123 twz123 deleted the replace-pkg-errors branch December 20, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants