Separate image building workflow from release workflow with improvements #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42 The image publish part was extracted from the release.yaml and moved to publish-images.yaml. The new publish-images workflow's functionality was modified: - On a tagged release (when binaries are released) the workflow will publish version-tagged versions of all machine images eg. quay.io/k0sproject/footloose-debian12:v1.2.3 - On a PR merge to main where Dockerfiles were modified, all the changed images will be built and published with the tag :latest, eg. quay.io/k0sproject/footloose-debian12:latest - If the workflow is dispatched manually, all images will be built and published as :latest (or any tag set in the dispatch input). The end result of this is that: - Images are published as :latest as PRs are merged - Images are published as :v1.2.3 when binaries are released - All images can be manually published as :latest or any other tag when a need arises. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
The image publish part was extracted from the release.yaml and moved to
publish-images.yaml.
The new publish-images workflow's functionality was modified:
:latestwhen PRs containing Dockerfile changes are merged to main:v1.2.3(or whatever the version is) when binaries are released:latestor any other tags has been made possible