Use go 1.23.3 #141
Use go 1.23.3 #141
Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
go.mod
Outdated
| @@ -1,8 +1,8 @@ | |||
| module github.com/k0sproject/bootloose | |||
|
|
|||
| go 1.22.0 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
| go 1.23.0 | |
| go 1.23 |
There was a problem hiding this comment.
The version is now not pinned so binaries will be magically built and tests run with whatever 1.23 the CI has.
Maybe the version should be pinned in the workflow?
Co-authored-by: Tom Wieczorek <twz123@users.noreply.github.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
|
Maybe the toolchain should stay. Module consumers will not be affected by that and it would pin the CI tests and builds to a specific version without resorting to specifying it in each workflow yaml. I believe this is how it is intended to be used. |
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Yeah, I don't like that "let me auto-install the toolchain for you" thing and the "pinning to patch versions" in the mod file. I think the minimum supported Go version is good, but the actual toolchain should be at the caller's discretion 🤷 But what shall I say, Go decided differently and I have to remember to use GOTOOLCHAIN=local everywhere 😆
No description provided.