Don't mount cgroups read-only for cgroups V1 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Docker 25, read-only mounts will be recursively read-only. That spoils the fun for systemd. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
commented
Jun 26, 2024
| @@ -312,7 +312,7 @@ func (c *Cluster) createMachineRunArgs(machine *Machine, name string, i int) []s | |||
| "-v", "/sys/fs/cgroup:/sys/fs/cgroup:rw") | |||
|
|
|||
| } else { | |||
| runArgs = append(runArgs, "-v", "/sys/fs/cgroup:/sys/fs/cgroup:ro") | |||
There was a problem hiding this comment.
Non-recursive read-only mounts don't seem to be supported by the CLI, although they seem to be a thing if using the API directly.
kke
reviewed
Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Docker 25, read-only mounts will be recursively read-only. That spoils the fun for systemd.