Fix dev AKS credentials configmap name #987
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerospiel
approved these changes
Jan 30, 2025
Currently, its name matches the ConfigMap from config/dev/azure-credentials.yaml. If I run `make dev-azure-creds` followed by make `dev-aks-creds`, the Azure credentials ConfigMap gets overwritten with the AKS credentials (which is empty).
eromanova
force-pushed
the
aks-creds-fix
branch
from
d057256 to
4c799d0
Compare
Kshatrix
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, its name matches the ConfigMap from
config/dev/azure-credentials.yaml. If I runmake dev-azure-credsfollowed by makedev-aks-creds, the Azure credentials ConfigMap gets overwritten with the AKS credentials (which is empty since no creds propagation is required).