-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ready condition to Management resources #960
Merged
zerospiel
merged 2 commits into
k0rdent:main
from
ramessesii2:RAMESSES/management-conditions
Jan 27, 2025
Merged
add Ready condition to Management resources #960
zerospiel
merged 2 commits into
k0rdent:main
from
ramessesii2:RAMESSES/management-conditions
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e2be83
to
86a767a
Compare
zerospiel
previously approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but someone else should review
96328cb
to
8fcefa0
Compare
zerospiel
reviewed
Jan 27, 2025
5d986b5
to
c48f3de
Compare
eromanova
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I’ve left one comment for consideration.
Signed-off-by: Satyam Bhardwaj <sbhardwaj@mirantis.com>
c48f3de
to
60e4ff4
Compare
eromanova
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces a
Ready
Condition and new printer columns in the Management CRD making it possible to look at the readiness of Management object at a glance along with release version.✅ Unit Tests
✅ Fixes #807
Kubectl gets the following:
Click to check an example Status generated