Skip to content

Commit

Permalink
Re-add SC1091 (#13)
Browse files Browse the repository at this point in the history
  • Loading branch information
jzombie authored Jan 2, 2024
1 parent eb7d54a commit 83bfaab
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions pipper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ activate_venv() {
if [ "$activate" = true ]; then
# Activate the virtual environment.
# shellcheck disable=SC1091
# Purpose: This directive is used to disable ShellCheck warning SC1091.
# Context: Warning SC1091 is triggered when ShellCheck encounters a 'source' or '.'
# command that includes a file not specified as input. This often happens
# when sourcing external scripts, such as activation scripts for virtual
# environments or other scripts that are not part of the project's repository.
# Reason for Disabling:
# - The files being sourced are dynamically generated (like Python virtualenv's 'activate' script),
# and not available for ShellCheck to analyze.
# - These files are standard and trusted, thus not posing a risk that necessitates ShellCheck analysis.
# - Disabling this warning allows us to use such scripts without ShellCheck flagging them as issues,
# keeping the focus on actual potential problems in the script's own code.
source "$VENV_NAME/bin/activate"
else
# Display instructions on how to activate the environment manually.
Expand Down

0 comments on commit 83bfaab

Please sign in to comment.