Try running Buster #186
Merged
Try running Buster #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1833f41.
Bumps [mysql2](https://github.com/brianmario/mysql2) from 0.3.21 to 0.5.2. - [Release notes](https://github.com/brianmario/mysql2/releases) - [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md) - [Commits](brianmario/mysql2@0.3.21...0.5.2) Signed-off-by: dependabot[bot] <support@dependabot.com>
|
Hi @jywarren a little help here I'm able to build a container of debian 10 with correct ruby and npm dependencies and run the tests, but they are failing because of a path issue (see https://travis-ci.com/jywarren/mapknitter/builds/104347200#L5276 for the log line) Maybe we're not at the app root? Thanks for your pointers! |
icarito
commented
Mar 15, 2019
| WORKDIR /tmp | ||
| ADD Gemfile /tmp/Gemfile | ||
| ADD Gemfile.lock /tmp/Gemfile.lock | ||
| RUN bundle install | ||
|
|
||
| # HOTFIX Workaround for mysql2 gem incompatibility with libmariadb-dev | ||
| RUN sed -i "s/ LONG_PASSWORD |//g" /usr/local/rvm/gems/ruby-*/gems/mysql2-*/lib/mysql2/client.rb |
There was a problem hiding this comment.
Here be dragons, we're monkey patching mysql2 gem here to make it work with libmariadb-compat-dev in Debian buster
|
Hooray!!!! Merging!!! |
jywarren
pushed a commit
that referenced
this pull request
Mar 16, 2019
* Try running Buster * Include binary GDal * Reorder Dockerfile * Install npm * Tweak apt command * Update Dockerfile * Simplfy * Rollback ruby upgrade and rather install 2.4.4 from rvm * Add login shell to support rvm * Mysql deps * Include git * Fix entry command * Move start command * Revert "Fix entry command" This reverts commit 1833f41. * Remove entrypoint from Dockerfile * Add -l parameter to bash * More deps * Bump mysql2 from 0.3.21 to 0.5.2 Bumps [mysql2](https://github.com/brianmario/mysql2) from 0.3.21 to 0.5.2. - [Release notes](https://github.com/brianmario/mysql2/releases) - [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md) - [Commits](brianmario/mysql2@0.3.21...0.5.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * activerecord-mysql2-adapter * Return to mysql2 < 4 gem and add some grease * Update exporter_test.rb * Update exporter_test.rb * Update exporter.rb * Update exporter_test.rb
jywarren
added a commit
that referenced
this pull request
Mar 21, 2019
* starting to move things into exporter lib, parameterize * additional mysql2 adapter change, sqlite compatibility * moved almost all of exporter code into ruby lib * Try to update GDAL from sources * Update Dockerfile * Try running Buster (#186) * Try running Buster * Include binary GDal * Reorder Dockerfile * Install npm * Tweak apt command * Update Dockerfile * Simplfy * Rollback ruby upgrade and rather install 2.4.4 from rvm * Add login shell to support rvm * Mysql deps * Include git * Fix entry command * Move start command * Revert "Fix entry command" This reverts commit 1833f41. * Remove entrypoint from Dockerfile * Add -l parameter to bash * More deps * Bump mysql2 from 0.3.21 to 0.5.2 Bumps [mysql2](https://github.com/brianmario/mysql2) from 0.3.21 to 0.5.2. - [Release notes](https://github.com/brianmario/mysql2/releases) - [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md) - [Commits](brianmario/mysql2@0.3.21...0.5.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * activerecord-mysql2-adapter * Return to mysql2 < 4 gem and add some grease * Update exporter_test.rb * Update exporter_test.rb * Update exporter.rb * Update exporter_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake testThanks!