Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashed search params generate invalid code #828

Closed
olehmisar opened this issue Jan 11, 2025 · 5 comments
Closed

Dashed search params generate invalid code #828

olehmisar opened this issue Jan 11, 2025 · 5 comments

Comments

@olehmisar
Copy link

Describe the bug

kitRoutes<KIT_ROUTES>({
  PAGES: {
    "myroute": {
      explicit_search_params: {
        "search-param": { required: true },
      },
    },
  },
})

Produces invalid PAGES and KIT_ROUTES code.

const PAGES = {
  "myroute": (params: { search-param: (string | number) }) => {

Severity

serious, but I can work around it

Steps to Reproduce the Bug

See above

Reproduction

No response

@jycouet
Copy link
Owner

jycouet commented Jan 12, 2025

Thank you for reporting, I'll have a look

jycouet added a commit that referenced this issue Jan 12, 2025
@jycouet
Copy link
Owner

jycouet commented Jan 12, 2025

May you test vite-plugin-kit-routes@0.7.6-next.0 and let me know ?

@jycouet jycouet reopened this Jan 12, 2025
@jycouet
Copy link
Owner

jycouet commented Jan 23, 2025

@all-contributors please add @olehmisar for bug

Copy link
Contributor

@jycouet

I've put up a pull request to add @olehmisar! 🎉

@jycouet
Copy link
Owner

jycouet commented Jan 23, 2025

Should be in vite-plugin-kit-routes@0.7.6

@jycouet jycouet closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants