Progress in app + sys mem fallback fix #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Awesome work |
|
Thank you for the pull request. Just one small concern: does it slow down the generation significantly by calling |
|
It does slow generation down, though I'm not sure by how much. Testing now. |
|
Without this PR: 441.83 sec About 8 second at 16 steps |
This seems acceptable, I will merge it. Thanks again. |
|
Mine is still flooding into system memory and its slowing the generation down to nearly a halt. I opened this issue about it: #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a progress bar in the app as well as adding a fix for flooding into system memory.
Previously, cache "stepped up" as the process continued, which de-allocated when it reached the max amount. When sys mem fallback is enabled, the ceiling is raised so it doesn't de-allocate and instead enters system memory.
Step up effect is shown here:
This fix collects cache after each step, stopping this effect:
Also, added a progress bar and pipeline callback:
