Handle empty string as token value #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the token is the empty string we try to pass `nil` to `Base64.url_decode`, which always expects a string. This ensures we always pass a string to avoid an unexpected error.
ragalie
force-pushed
the
handle-empty-string-as-token
branch
from
2bf6a2a to
3b17ccb
Compare
anakinj
approved these changes
Dec 13, 2024
|
Nice, thanks for the fix @ragalie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the token is the empty string we try to pass
niltoBase64.url_decode, which always expects a string.This ensures we always pass a string to avoid an unexpected error.
Checklist
Before the PR can be merged be sure the following are checked: