Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply the combobox's internal state handling of the open-state #926

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

haukesomm
Copy link
Collaborator

This PR simplifies the combobox's internal state handling in order to fix an issue related to its open-state and make it more robust in general:

  • The open state of the combobox is no longer managed inside the component itself but instead fully controlled by the OpenClose mixin, making it more robust
  • A regression test for an issue resulting in infinite opening and closing of the dropdown is added
  • The component demo is restructured to allow more complex testing in the future: It is now split in two parts - the public demo and internal test drives. Some parts of the demo are moved from the public example to the internal testdrive.

@haukesomm haukesomm added the headless All about headless components and foundations label Dec 9, 2024
@haukesomm haukesomm force-pushed the haukesomm/fix-combobox-autoselect branch from c592a0f to b621961 Compare December 9, 2024 11:21
@haukesomm haukesomm added this to the 1.0-RC20 milestone Dec 9, 2024
@haukesomm haukesomm marked this pull request as ready for review December 9, 2024 14:34
@haukesomm haukesomm requested a review from Lysander December 9, 2024 14:34
@haukesomm haukesomm merged commit 19c559e into master Dec 9, 2024
2 checks passed
@haukesomm haukesomm deleted the haukesomm/fix-combobox-autoselect branch December 9, 2024 16:10
haukesomm added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
headless All about headless components and foundations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants