Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the combobox deleting input when the rendering is slow #909

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

haukesomm
Copy link
Collaborator

@haukesomm haukesomm commented Oct 18, 2024

This PR fixes a bug in the headless combobox component where parts of the input are deleted/reset when the user types fast and the rendering is slow.

Additionally, a few compiler warnings introduced with the Kotlin 2.0 upgrade are resolved.

@haukesomm haukesomm added bug Something isn't working headless All about headless components and foundations labels Oct 18, 2024
@haukesomm haukesomm added this to the 1.0-RC20 milestone Oct 18, 2024
@haukesomm haukesomm requested a review from Lysander October 18, 2024 10:19
@haukesomm haukesomm marked this pull request as draft October 18, 2024 10:43
@haukesomm haukesomm force-pushed the haukesomm/fix-combobox-input branch from 370e796 to ee40fda Compare October 18, 2024 10:51
@haukesomm haukesomm marked this pull request as ready for review October 18, 2024 10:51
@haukesomm haukesomm changed the title Fixes the combobox deleting input when slow Fixes the combobox deleting input when the rendering is slow Oct 18, 2024
Lysander
Lysander previously approved these changes Oct 18, 2024
This commit fixes a bug in the headless combobox component where parts of the
input are deleted/reset when the user types fast and the rendering is slow.
@haukesomm haukesomm merged commit 2f1868c into master Oct 21, 2024
2 checks passed
@haukesomm haukesomm deleted the haukesomm/fix-combobox-input branch October 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working headless All about headless components and foundations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants