Fix focus-trap for firefox tests #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lysander
approved these changes
Feb 1, 2024
Lysander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fritz2 Event-Flows the calls for preventDefault and stopImmediatePropagation will be delayed slightly, so that the Browser might already perform the Tab Operation. To prevent this behaviour we have to use a plain JS Listener, which directly calls preventDefault and stopImmediatePropagation.
It is difficult to reproduce this problem with user interaction, but Tabbing with Playwright-Tests on Firefox causes duplicate Tab events (Browser-Default + Fritz2-Focustrap).
Using Event-Flows with preventDefault and/or stop(Immediate)Propagation might also cause other problems, but that there is no way to fix this globally in Fritz2, because Event-Handling heavily depends on Flows and Job-Handling.