Add Scope handling for Portal Containers #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lysander
requested changes
Dec 18, 2023
headless/src/jsMain/kotlin/dev/fritz2/headless/components/toast.kt
Outdated
Show resolved
Hide resolved
headless/src/jsMain/kotlin/dev/fritz2/headless/foundation/portalling.kt
Outdated
Show resolved
Hide resolved
Lysander
approved these changes
Dec 21, 2023
Lysander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #781 we added portalling, but portals currently do not inherit any scope.
In this PR portal-containers get a scope of some defined parent tags.
We have two types of portals:
Bound to the ViewPort:
These Portals will inherit the Scope of the PortalRoot, which inherits the Scope of its parent (usually the main render Function).
Both the portalRoot() function and the global render() function got a scope parameter, so the user can set scopes as for every tag.
The second type of portals is bound to a reference element:
These portals inherit the scope of their reference element, to which they get aligned.