Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Tracker to use Boolean as state #740

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

jwstegemann
Copy link
Owner

@jwstegemann jwstegemann commented Jan 20, 2023

Until now, a tracker could distinguish several different transactions that could be passed as a parameter to the track function. This rarely needed functionality can be implemented by using multiple trackers (whose data streams can be combined if needed). This can significantly simplify the tracker's implementation.
Specifying a transaction as a parameter of track is no longer possible. Appropriately, no defaultTransaction can be defined in the factory either. Likewise, the possibility to get a flow, which checks whether a certain transaction is running, by invoking the Tracker is omitted.

Solves #736

@jwstegemann jwstegemann requested a review from a user January 20, 2023 09:33
@jwstegemann jwstegemann self-assigned this Jan 20, 2023
@jwstegemann jwstegemann added the api breaking Forces client sources to change label Jan 20, 2023
@jwstegemann jwstegemann marked this pull request as ready for review January 20, 2023 10:05
@jwstegemann jwstegemann added this to the 1.0-RC3 milestone Jan 20, 2023
@jwstegemann jwstegemann linked an issue Jan 20, 2023 that may be closed by this pull request
@jamowei jamowei merged commit dd01959 into master Jan 23, 2023
@jamowei jamowei deleted the jwstegemann/simplifyTracking branch January 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking Forces client sources to change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Tracking API
2 participants