Improve Headless Input API #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the ``type`` is no longer a (poorly) encapsulated attribute offered by ``inputField``. This makes the internal code much simpler and would theoretically allow to choose the tag for ``inputTextfiled`` in the future. - correct small ID setting mistake in checkboxGroup component - add some useful remark in the playwright readme for local testing.
ghost
requested review from
ghost
self-assigned this
ghost
added
api breaking
haukesomm
approved these changes
Sep 6, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fixes
The
typeis no longer a (poorly) encapsulated attribute offered byinputField. This makes the internal code much simpler and would theoretically allow to choose the tag forinputTextfiledin the future.fixes #678
Additional fixes