-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PopupComponent
#493
Merged
Merged
Add PopupComponent
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components/src/jsMain/kotlin/dev/fritz2/components/popper.kt # components/src/jsMain/kotlin/dev/fritz2/components/popper/component.kt # styling/src/jsMain/kotlin/dev/fritz2/styling/theme/default.kt
Merged
ghost
previously approved these changes
Aug 25, 2021
- correct some minor documentation issues - repairs and enhances example calls - some minor formatting improvements - revokes some irritating renaming of a DataTable's event (obviously was mistakenly applied)
ghost
approved these changes
Aug 25, 2021
ghost
deleted the
westhuus/popperComponent
branch
August 25, 2021 12:53
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PopupComponent
should be used for to positioningcontent
liketooltip
orpopover
automatically in the right place near atrigger
.A
popup
mainly consists of atrigger
(the Element(s)) which calls thecontent
.It can cen configured by
offset
the space (in px) betweentrigger
andcontent
flipping
if no space on chosen available it will be find a right placement automaticallyplacement
of thecontent
around thetrigger
The
trigger
provides two handler which can be used, the first is important to open/toggle thecontent
the second close it.content
provides one handler which can be used to close it.Example:
resolves #447
this PR needs #486 and #481 before it can be merged