Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename alert variant discreet to ghost #462

Merged
1 commit merged into from
Jul 13, 2021

Conversation

haukesomm
Copy link
Collaborator

This PR renames the discreet alert-variant to ghost in order to match the common naming scheme of fritz2.

All references of discreet have to be changed:

alert {
    variant { discreet } // <-- previously
    variant { ghost } // <-- now
}

Closes #439 .

@haukesomm haukesomm added api improvement api breaking Forces client sources to change labels Jun 28, 2021
@haukesomm haukesomm added this to the 0.12 milestone Jun 28, 2021
@haukesomm haukesomm requested a review from a user June 28, 2021 12:09
@haukesomm haukesomm self-assigned this Jun 28, 2021
@haukesomm haukesomm changed the title Rename alert variant 'discreet' to 'ghost' Rename alert variant discreet to ghost Jun 28, 2021
@ghost ghost merged commit 44cc609 into master Jul 13, 2021
@ghost ghost deleted the haukesomm/al-rename-discreet-ghost branch July 13, 2021 11:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking Forces client sources to change api improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename alert variant discreet to ghost to be compliant to the rest of the components
1 participant