Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Error and warning standardization #96

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[BUG] Error and warning standardization #96

merged 1 commit into from
Oct 21, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Ensure warning and errors are the same for both platforms
  • Ensure native events are passed to react side

Why is this Pull Request needed?

  • Errors weren't being surfaced (sometimes)
  • Info in warnings and errors was missing information

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner October 17, 2024 19:14
kcorneli201
kcorneli201 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@kcorneli201 kcorneli201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jmilham21 Standardized error and warning messaging LGTM.

@Jmilham21 Jmilham21 merged commit 83c1fd2 into master Oct 21, 2024
@Jmilham21 Jmilham21 deleted the bug/errors-not-showing-in-react-native branch October 21, 2024 19:46
@Jmilham21 Jmilham21 mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcorneli201 kcorneli201 kcorneli201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @kcorneli201