Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20 #65

Closed
rwgk opened this issue Jan 26, 2024 · 1 comment · Fixed by #66
Closed

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20 #65

rwgk opened this issue Jan 26, 2024 · 1 comment · Fixed by #66

Comments

@rwgk
Copy link

rwgk commented Jan 26, 2024

I'm seeing warnings like:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: jwlawson/actions-setup-cmake@v1.14. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

For example here: https://github.com/google/pywrapcc/actions/runs/7663060547

Is this already on your radar? The jobs finish fine, but the many warnings are easily distracting.

The corresponding GHA yml:

https://github.com/google/pywrapcc/blob/82d782474e8e43359dc95c282f1fa9b4ac2bb1bb/.github/workflows/ci.yml
@alkino alkino mentioned this issue Feb 5, 2024
Merged
joshstrohminger added a commit to joshstrohminger/actions-setup-cmake that referenced this issue Feb 5, 2024
@joshstrohminger
Update to use node20 (jwlawson#65)
815e924
@joshstrohminger joshstrohminger mentioned this issue Feb 5, 2024
Merged
@jwlawson
Copy link
Owner

jwlawson commented Feb 5, 2024

Thanks for bringing this to my attention, I wasn't aware. Big thanks to @joshstrohminger for looking into resolving this too.

jwlawson pushed a commit that referenced this issue Feb 6, 2024
@joshstrohminger
Run on Node 20 (#66)
8974e9c 
GitHub is no longer going to support running actions on Node 16 and requires upgrading to Node 20 (see blog). This PR addresses that with updates to:

 * action runtime
 * workflows
 * node types

Tests passed when run locally. Closes #65.

Add @types/node to devDependencies to ensure we get the proper version and bump @vercel/ncc to the latest, and update package-lock using `npm install` which also prepares the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run on Node 20 joshstrohminger/actions-setup-cmake
2 participants
@rwgk @jwlawson