PR 12198 #72
Open
PR 12198 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes usage of device type in unpackAndCombineWithOwningPIDsCount consistent with unpackAndCombineIntoCrsArrays for identical input parameters.
Add additional timers Optimization: only do deep copies if required by user option
Merges Tpetra_CrsMatrix methods unpackAndCombineWithOwningPIDsCount and
unpackAndCombineIntoCrsArrays. Reduces number of deep copies. Part of
larger effort to have TAFC run on device.
Temporary change in Tpetra_CrsMatrix_def.hpp:
destMat->numImportPacketsPerLID_.modify_host()
because numImportPacketsPerLID_ is a Kokkos::DualView and hasn't been
properly marked as modified on host
Addresses trilinos#11693 and trilinos#11694.
Replace unpackAndCombineIntoCrsArrays version that accepts only Teuchos Arrays/ArrayRCPs with one that accepts some Kokkos views. (The conversion isn't complete, as upstream/downstream changes are still to be done.) Part of trilinos#11693 and trilinos#11694.
Update unpackAndCombineIntoCrsArrays unit test. Leverage the fact that Tpetra::Details::Transfer has methods for returning Kokkos::DualViews for remote, permuteTo, and permuteFrom LIDs. Part of trilinos#11693.
In response to review of PR trilinos#12036.
In response to review comment for PR trilinos#12036.
…ombine-new Automatically Merged using Trilinos Pull Request AutoTester PR Title: b'Tpetra: move unpack and combine to device in TAFC' PR Author: jhux2
Adding whitespace to rerun Metrix++ GH Action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating PR 12198 to study complexity.