Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Directly write video html to data-video #18

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[TASK] Directly write video html to data-video #18

merged 1 commit into from
Feb 18, 2020

Conversation

t3easy
Copy link
Contributor

@t3easy t3easy commented Feb 14, 2020

Resolves: #17

@pascal20997 pascal20997 self-assigned this Feb 17, 2020
@pascal20997 pascal20997 added the enhancement New feature or request label Feb 17, 2020
@pascal20997
Copy link
Contributor

Hello Jan,

that´s a good idea. I´ll check that tomorrow :)

@t3easy
Copy link
Contributor Author

t3easy commented Feb 17, 2020

You can deprecate the VideoViewHelper after this change.

pascal20997
pascal20997 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@pascal20997 pascal20997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Thanks :)

@pascal20997 pascal20997 merged commit dc7e0d2 into jweiland-net:master Feb 18, 2020
@t3easy t3easy deleted the 17 branch February 18, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal20997 pascal20997 pascal20997 approved these changes

Assignees

@pascal20997 pascal20997

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use data-video directly to store video html
2 participants
@t3easy @pascal20997