Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High level release function #34

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

GunnarFarneback
Copy link
Collaborator

Implementation of a release function for InferenceSession.

Fixes #33.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4688a1a) 88.18% compared to head (098582a) 88.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   88.18%   88.37%   +0.18%     
==========================================
  Files           4        4              
  Lines         381      387       +6     
==========================================
+ Hits          336      342       +6     
  Misses         45       45              
Files Coverage Δ
src/highlevel.jl 85.55% <100.00%> (+1.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/highlevel.jl Outdated Show resolved Hide resolved
Copy link
Owner

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, two minor suggestions above this is a nice addition and looks good overall.

@jw3126
Copy link
Owner

jw3126 commented Oct 19, 2023

You might also want to bump the version.

@jw3126 jw3126 merged commit 5ed108b into jw3126:main Oct 19, 2023
7 of 10 checks passed
@GunnarFarneback GunnarFarneback deleted the highlevel_release branch October 19, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual release of memory
3 participants