Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add imports to allow experimental_python_import_all_repositories #86

Conversation

ewianda
Copy link
Contributor

@ewianda ewianda commented Mar 25, 2024

This fixes breakage for users of this repository when --experimental_python_import_all_repositories=false is set, which the Bazel team would like to do in bazelbuild/bazel#2636.

See also bazelbuild/rules_python#792

Without this change, users get the error:.

runfiles/rules_pycross/pycross/private/tools/wheel_installer.py", line 14, in <module>
    from pycross.private.tools import namespace_pkgs
ModuleNotFoundError: No module named 'pycross'

@jvolkman
Copy link
Owner

Thanks! I'll need to investigate this test failure.

@ewianda
Copy link
Contributor Author

ewianda commented Apr 12, 2024

Hi @jvolkman was wondering if you had a chance to look at this.

@jvolkman
Copy link
Owner

I fixed the test issue in main, so I'll merge this now.

@jvolkman jvolkman merged commit dcde272 into jvolkman:main Apr 15, 2024
21 of 22 checks passed
@ewianda ewianda deleted the handle-experimental_python_import_all_repositories branch April 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants