feat: support modifiers proposal #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
approved these changes
Jun 15, 2022
parser.js
Outdated
| skip(":"); | ||
| modifiersGroup.body = parseDisjunction(); | ||
| if (!modifiersGroup.body) { | ||
| bail('Expected disjunction'); |
There was a problem hiding this comment.
Can you add a test case for this branch?
There was a problem hiding this comment.
I can't find such an example.😰
There was a problem hiding this comment.
Does /(?i:)/ or /(?i:|)/ throw?
|
Thanks for all the work on this one. I plan to take a look over the weekend. |
|
Can you also update Line 3 in e66d3d0 |
|
There’s some tests for types too :) |
tjenkinson
reviewed
Jun 16, 2022
mathiasbynens
approved these changes
Jun 19, 2022
|
This looks overall good to me. Let's figure out the latest discussion about "We should parse [...]" and then this should be good to go. |
nicolo-ribaudo
approved these changes
Jun 24, 2022
|
Thank you all for working on this one. I've created a new npm release 0.9.0 of the library including this change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/tc39/proposal-regexp-modifiers