refactor: use active speed threshold

jvandenaardweg · Dec 28, 2022 · 0d0d6eb · 0d0d6eb
1 parent ce55e61
commit 0d0d6eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/fan-accessory.ts b/src/fan-accessory.ts
@@ -3,6 +3,7 @@ import { Service, PlatformAccessory, CharacteristicValue, Nullable } from 'homeb
 import { HomebridgeIthoDaalderop } from '@/platform';
 import { IthoDaalderopAccessoryContext, IthoStatusSanitizedPayload } from './types';
 import {
+  ACTIVE_SPEED_THRESHOLD,
   DEFAULT_FAN_NAME,
   MANUFACTURER,
   MAX_ROTATION_SPEED,
@@ -328,7 +329,7 @@ export class FanAccessory {
       return;
     }
 
-    if (rotationSpeed < 10) {
+    if (rotationSpeed < ACTIVE_SPEED_THRESHOLD) {
       if (currentFanStateValue === this.platform.Characteristic.CurrentFanState.IDLE) {
         this.log.debug(`CurrentFanState: Already set to: ${currentFanStateName}. Ignoring.`);
         return;
@@ -418,7 +419,7 @@ export class FanAccessory {
 
     // A rotation speed of 0 will turn the fan off
     // A rotation speed of 20 will turn the fan on
-    const speedValue = activate ? 20 : 0;
+    const speedValue = activate ? ACTIVE_SPEED_THRESHOLD : 0;
 
     if (this.mqttApiClient) {
       this.mqttApiClient.setSpeed(speedValue);

diff --git a/src/settings.ts b/src/settings.ts
@@ -37,3 +37,6 @@ export const MQTT_CMD_TOPIC = 'itho/cmd';
 
 // https://developers.homebridge.io/#/characteristic/RotationSpeed
 export const MAX_ROTATION_SPEED = 100;
+
+/** Any value above this value is considered "active" */
+export const ACTIVE_SPEED_THRESHOLD = 20;