Support for Git-LFS #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaaletto
force-pushed
the
master
branch
2 times, most recently
from
13fdf16 to
6132435
Compare
Update CI jobs
* Remove files not needed * update ci script
|
Thanks for this, a great idea! I'll isolate the test for it in the CI workflow + minor formatting hygiene and merge it soon. Cheers 🍻 |
jv-k
added
enhancement
|
Hi, actually I kept on working on my forked master and I have personalized it as per my needs, adding also a new input parameter to enable/disable the creation of a commit. |
|
Yes, I saw that. The option to disable the commit is a good idea for the scenario where the output file is used for another purpose, eg continuous deployment, and not required to be part of the repo. I'll add it too, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the .ai files are stored with Git-LFS and the repo is configured with LFS, the CI job throws this error:
\nThis repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting '.git/hooks/post-commit'.\nmeaning that git-lfs bin is not available in the bin PATH of Docker container.
With this PR I'm requesting in the Dockerfile to install also git-lfs
Hoping this could be useful.
Regards,
Andrea