Skip to content

Commit

Permalink
chore(build): disable arm build temporarily
Browse files Browse the repository at this point in the history
The binaries for better-sqlite3 v10 aren't currently available on ARM
due to Github Action flakiness:

WiseLibs/better-sqlite3#1186
  • Loading branch information
justmoon committed May 17, 2024
1 parent f45aa7e commit cb7901b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
7 changes: 5 additions & 2 deletions packages/app-build/src/cli-options/architectures.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import { Type } from "cmd-ts"
import { z } from "zod"

import { Architecture } from "../constants/architectures"
import {
Architecture,
SUPPORTED_ARCHITECTURES,
} from "../constants/architectures"

const ArchitectureSchema = z.array(z.enum(["x64", "arm64", "armv7l"]))
const ArchitectureSchema = z.array(z.enum(SUPPORTED_ARCHITECTURES))

export const ArchitecturesParameter: Type<string, readonly Architecture[]> = {
from: (value) => {
Expand Down
7 changes: 6 additions & 1 deletion packages/app-build/src/constants/architectures.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
export const SUPPORTED_ARCHITECTURES = ["x64", "arm64", "armv7l"] as const
export const SUPPORTED_ARCHITECTURES = [
"x64",
// TODO: Re-enable ARM build once better-sqlite3 v10 binaries are available
//"arm64",
//"armv7l",
] as const

export type Architecture = (typeof SUPPORTED_ARCHITECTURES)[number]
4 changes: 2 additions & 2 deletions packages/app-build/src/steps/download-better-sqlite3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type SqliteArchitecture = "x64" | "arm" | "arm64"
export const SQLITE_ARCHITECTURE_MAP: {
[key in Architecture]: SqliteArchitecture
} = {
armv7l: "arm",
arm64: "arm64",
// armv7l: "arm",
// arm64: "arm64",
x64: "x64",
}

Expand Down

0 comments on commit cb7901b

Please sign in to comment.