globalpackages: add enable/disable/toggle subcommands, add help #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
justinmayer
requested changes
Nov 18, 2020
Old behavior (toggle) is preserved when calling with no specific action. Printing of the new status can now be disabled with the -q/--quiet switch.
airwoodix
force-pushed
the
enh-globalpackages
branch
from
5408229 to
9954f03
Compare
|
Thanks for the feedback! Using long options sounds good to me. I'd go for the short version if there's something widely used/idiomatic but that's definitely not the case here. Sorry for the faulty copy-paste (I guess leaving the duplicated comment is good to avoid messing up with the next line at all spots). |
justinmayer
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This patch implements explicit actions for
vf globalpackagesas discussed in #181. The old behavior (toggle) is preserved when calling with no explicit action. I also added a-q/--quietswitch to remove the new state display. Finally, reworking this was the opportunity to add a help message, following the incentive in #105.New usage:
vf globalpackages [-q]: toggle use of system site packagesvf globalpackages toggle [-q]: same as abovevf globalpackages enable [-q]: enable system site packagesvf globalpackages disable [-q]: disable system site packagesThe command returns 0 up success.
Comments most welcome. Thanks!