Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

started mysql db #1477

Open
wants to merge 152 commits into
base: master
Choose a base branch
from
Open

started mysql db #1477

wants to merge 152 commits into from

Conversation

TheSnewby
Copy link

  • wrote task 3: setup_mysql_dev.sql
  • added a space between author names in README.md

TheSnewby and others added 30 commits October 19, 2024 13:41
@TheSnewby
updated AUTHORS in readme, still needs Malik's
ec11b04
@SpaceDandy15
added github to readme
b21e592
@SpaceDandy15
fixed whitespace issues, blank lines basically fixing pycodestyle iss…
77ed8c4 
…ues.
@SpaceDandy15
used isinstance instead of type for readability and pythonic style.
9dcb5b7
@SpaceDandy15
white space and indention
781b9f5
@SpaceDandy15
moved comment above code
197ca9a
@SpaceDandy15
string concatenation line 309
be37a64
@SpaceDandy15
extra line
6309b66
@SpaceDandy15
over indention line 48
d0516b6
@SpaceDandy15
checker wants database storage. i added the file with some code to st…
e81f6be 
…art with.
@SpaceDandy15
line 18 was too long
ef78e20
@SpaceDandy15
i added tester for console.
cc82750
@SpaceDandy15
needed extra blank line at the end
31d04cd
@SpaceDandy15
added unittest.mock to reseolve name error and then also added a chec…
45e6759 
…k for the name attribute. (test do update)
@SpaceDandy15
line 84 blank line with whitepace.
3c3f33d
@SpaceDandy15
added a do create show destroy and update for test file. Then for con…
ef90a28 
…sole i fixed input validations and adjusted the do all method.
@SpaceDandy15
pycode fixes
797efbb
@SpaceDandy15
message is split into two separate print statements. This keeps each …
a384fba 
…line short and improves readability while maintaining the full message clarity.
@SpaceDandy15
trying to shorten line 308
702aff1
@SpaceDandy15
line spacing
4883451
@SpaceDandy15
the battle of 308
51df4da
@SpaceDandy15
pycode
2904eb6 
pep8
@SpaceDandy15
pep8
4c9f824
@SpaceDandy15
last attempt fo now
a03376c
@SpaceDandy15
line 309 just too dang long
a35b75e
@TheSnewby
adding .gitignore
29fe5c7
@TheSnewby
setup_mysql_dev.sql
84b1d03
@TheSnewby
adjusted readme clarity
b385d1c
@TheSnewby
Merge pull request #1 from TheSnewby/snewby
62e70b0 
task 3
@TheSnewby
added .* to databases when granting privileges
f7cd09f
SpaceDandy15 and others added 30 commits October 27, 2024 12:38
@SpaceDandy15
had merge conflict so just pushed what i had and then redid file storage
efe89ff
@TheSnewby
Merge branch 'master' into snewby
98cc28a
@SpaceDandy15
updated basemodel
69433c3
@TheSnewby
Merge branch 'master' into snewby
0bb2959 
merge
@SpaceDandy15
quick swap
92952df
@TheSnewby
Merge branch 'master' into snewby
48baf38 
1:55pm
@TheSnewby
base_model multiple fixes
a74cd53
@TheSnewby
Merge pull request #30 from TheSnewby/snewby
9873043 
Basemodel.py fixes
@TheSnewby
reverted do_update to original with minor changes
c2e2751
@TheSnewby
update workign again
15830d5
@TheSnewby
Merge pull request #31 from TheSnewby/snewby
000517f 
do_update and related methods working again
@TheSnewby
removed BaseModel from db_storage as it has no corresponding tablenam…
ca0bb66 
…e. removed two sections of code in base_model as one was redundant and the keyerror was breaking the program
@TheSnewby
Merge pull request #32 from TheSnewby/snewby
c7430ca 
small fix to basemodel and dbstorage
@TheSnewby
fixed relationships in Place, Review, User, City and some of Amenity
7d0f336
@TheSnewby
Merge pull request #33 from TheSnewby/snewby
3e500fe 
fixed relationships in Place, Review, User, City and some of Amenity
@TheSnewby
current backup
8ed64cb
@TheSnewby
db_storage now updates console
93174fc
@TheSnewby
Merge pull request #34 from TheSnewby/snewby
7bc5876 
Amenity and DBStorage stable
@TheSnewby
reverting all changes to setup_mysql_dev.sql
eb562bc
@TheSnewby
Merge pull request #35 from TheSnewby/snewby
f86c976 
reverting all changes to setup_mysql_dev.sql
@TheSnewby
PEP8 and removed silly test
1e64258
@TheSnewby
Merge pull request #36 from TheSnewby/snewby
98d0387 
PEP8 and removed silly test
@TheSnewby
skipped unittests that don't work with dbstorage
b7f353e
@TheSnewby
Merge pull request #37 from TheSnewby/snewby
9f70376 
Used skipIf on unittests that don't work with dbstorage
@TheSnewby
DBStorage tests for all models
f17d9db
@TheSnewby
Merge pull request #38 from TheSnewby/snewby
1dfab38 
DBStorage tests for all models
@SpaceDandy15
Added unit test for dbstorage.
2c635da
@TheSnewby
pycode, f-strings, unittests
2a2f68f
@TheSnewby
web_flask
909033a
@TheSnewby
README
00ac599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSnewby @SpaceDandy15