fix: error on windows with no battery #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules
* feat(util): use test command to check directory * fix: use single quotes in util/file.lua * feat(util): add type hints and documentation, remove old function * feat(parsers): move all parsers to their own submodule (justinhj#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * feat(util): use old "readable directory" method when not in Termux
|
Works great! |
Agent-E11
added a commit
to Agent-E11/battery.nvim
that referenced
this pull request
Jul 22, 2024
* feat(parsers): move all parsers to their own submodule (justinhj#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * fix: Termux compatible `is_readable_directory` function (justinhj#42) * feat(util): use test command to check directory * fix: use single quotes in util/file.lua * feat(util): add type hints and documentation, remove old function * feat(parsers): move all parsers to their own submodule (justinhj#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * feat(util): use old "readable directory" method when not in Termux * docs: start adding type definitions * docs: consistent doc-comment * fix(parsers/powershell): default to 2 when no batteries
justinhj
pushed a commit
that referenced
this pull request
Sep 8, 2024
* feat(parsers): move all parsers to their own submodule (#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * fix: Termux compatible `is_readable_directory` function (#42) * feat(util): use test command to check directory * fix: use single quotes in util/file.lua * feat(util): add type hints and documentation, remove old function * feat(parsers): move all parsers to their own submodule (#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * feat(util): use old "readable directory" method when not in Termux * docs: start adding type definitions * docs: consistent doc-comment * fix: error on windows with no battery (#51) * feat(parsers): move all parsers to their own submodule (#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * fix: Termux compatible `is_readable_directory` function (#42) * feat(util): use test command to check directory * fix: use single quotes in util/file.lua * feat(util): add type hints and documentation, remove old function * feat(parsers): move all parsers to their own submodule (#43) BREAKING CHANGE: Parser modules have been moved Add `check` functions to all parser modules * feat(util): use old "readable directory" method when not in Termux * docs: start adding type definitions * docs: consistent doc-comment * fix(parsers/powershell): default to 2 when no batteries * fix(parsers): check if `vim.fn.has()` is `1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no batteries on Windows, the
batteriesvariable is an empty list. Previously, the first battery was indexed before verifying whether there was a first battery, which would cause a crash if there were no batteries.Fix this so that it only gets the status of the first battery if there is one, and defaults to
2if there isn't one.Close #50