Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to parse multi-component extensions like ".a.ext" #26

Closed
justinfx opened this issue May 29, 2023 · 0 comments · Fixed by #27
Closed

Fails to parse multi-component extensions like ".a.ext" #26

justinfx opened this issue May 29, 2023 · 0 comments · Fixed by #27
Assignees
@justinfx
Labels
bug c++ go Go implementation

Comments

@justinfx
Copy link
Owner

Both the Go and C++ implementations have a bug when dealing with multi-component file extension patterns, when one of the components contains only a single characters:

file.1.a.ext

In this case, the base vs frame vs ext is not captured correctly, leading to breakages in both FileSequence ctor and calls to FindSequenceOnDisk()
@justinfx justinfx added bug c++ go Go implementation labels May 29, 2023
@justinfx justinfx self-assigned this May 29, 2023
justinfx added a commit that referenced this issue May 29, 2023
@justinfx
go/cpp: fix regex to handle complex extensions with single character …
ad4b53f 
…component (refs #26)
This was referenced May 29, 2023
Merged
Closed
justinfx added a commit that referenced this issue May 31, 2023
@justinfx
go/cpp: implement "template" sequence to pass through FindSequenceOnD…
20b64c3 
…isk and handle ambiguous frame patterns (refs #26)
justinfx added a commit that referenced this issue Jun 1, 2023
@justinfx
Merge pull request #27 from justinfx/026_ext_parse
c195a8b 
go/cpp: fix handling of complex extensions with single character component (refs #26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinfx justinfx

Labels
bug c++ go Go implementation
Projects
None yet
Milestone
No milestone
1 participant
@justinfx