Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package version overrides #759

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix package version overrides #759

merged 2 commits into from
Mar 14, 2024

Conversation

martincostello
Copy link
Member

  • Use VersionOverride and IsTargetFrameworkCompatible for System.Text.Json versions.
  • Fix net7.0 target not using the right version of System.Text.Json.
  • Simplify AoT properties.
  • Ignore dependabot package updates for System.Text.Json.

@martincostello
Ignore System.Text.Json
b075700 
Ignore package updates for System.Text.Json.
@martincostello
Fix package references
125307c 
- Use VersionOverride and IsTargetFrameworkCompatible for System.Text.Json versions.
- Fix net7.0 target not using the right version of System.Text.Json.
- Simplify AoT properties.
@martincostello martincostello added the bug A defect in the code or documentation. label Mar 14, 2024
@martincostello martincostello added this to the v4.2.1 milestone Mar 14, 2024
@martincostello martincostello requested a review from a team as a code owner March 14, 2024 17:37
@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Mar 14, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (f33d7bf) to head (125307c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          15       15           
  Lines         855      855           
  Branches      193      193           
=======================================
  Hits          849      849           
  Misses          4        4           
  Partials        2        2
Flag Coverage Δ
linux 99.29% <ø> (ø)
macos 99.29% <ø> (ø)
windows 99.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (rebase) March 14, 2024 17:40
@martincostello martincostello merged commit 6188e3f into main Mar 14, 2024
13 checks passed
@martincostello martincostello deleted the refactor-overrides branch March 14, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug A defect in the code or documentation. dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Milestone
v4.2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@martincostello