Support native AoT #729
Merged
Support native AoT #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unit analyser warning by using `TheoryData<T>`.
Fix benchmarks no longer running due to use of Artifacts Output and an incorrectly defined POCO property.
- Add support for native AoT for `net6.0` and `net7.0`. - Use `JsonSerializer.SerializeToUtf8Bytes()` where possible. - Fix `ArgumentException.ParamName` not being asserted on.
Update benchmarks after changes and fixes.
- Add unit tests for missing coverage. - Simplify some tests.
martincostello
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 96.93% 99.29% +2.36%
==========================================
Files 15 15
Lines 847 855 +8
Branches 193 193
==========================================
+ Hits 821 849 +28
+ Misses 22 4 -18
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add a unit test to help prevent the benchmarks get broken again in the future.
slang25
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net6.0andnet7.0.JsonSerializer.SerializeToUtf8Bytes()where possible.ArgumentException.ParamNamenot being asserted on.TheoryData<T>.