-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new language features #445
Merged
martincostello
merged 7 commits into
justeattakeaway:main
from
martincostello:use-new-language-features
May 14, 2022
Merged
Use new language features #445
martincostello
merged 7 commits into
justeattakeaway:main
from
martincostello:use-new-language-features
May 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `is null` and `is not null`.
Use expression-bodied method for minor refactor.
- Reduce line width. - Remove redundant namespace.
Use Uri constants instead of literals.
Do not try to template the string if it's empty.
Allocate collections with the appropriate capacity when the target size is known.
Add a test case for HTTP status codes that aren't defined in HttpStatusCode.
martincostello
added
the
enhancement
A change that enhances existing functionality or documentation.
label
May 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 699 704 +5
=========================================
+ Hits 699 704 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring to use various newer C# language features.
Also applies a few minor optimisations.