Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Newtonsoft.Json and unsupported TFMs #444

Merged

Conversation

martincostello
Copy link
Member

  • Remove net461 and net5.0 TFMs, as those versions are no longer supported.
  • Add net6.0 TFM.
  • Remove dependency on Newtonsoft.Json and just use System.Text.Json.
  • Update NuGet packages to their latest, or more recent, versions.
  • Add async overload for registering an HTTP bundle.
  • Remove redundant cast needed from net5.0 TFM.

Resolves #441.
Resolves #442.

@martincostello martincostello added enhancement A change that enhances existing functionality or documentation. dependencies Pull requests that update a dependency file labels May 14, 2022
@martincostello martincostello modified the milestones: Future, v4.0.0 May 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #444 (c8a5646) into main (0cbb0b0) will decrease coverage by 0.14%.
The diff coverage is 95.45%.

❗ Current head c8a5646 differs from pull request most recent head bf6b9ea. Consider uploading reports for the commit bf6b9ea to get more accurate results

@@             Coverage Diff             @@
##              main     #444      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           16       15       -1     
  Lines          704      705       +1     
===========================================
  Hits           704      704              
- Misses           0        1       +1     
Flag Coverage Δ
linux 99.85% <95.45%> (-0.15%) ⬇️
macos 99.85% <95.45%> (-0.15%) ⬇️
windows 99.85% <95.45%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HttpClientInterception/Bundles/Bundle.cs 100.00% <ø> (ø)
src/HttpClientInterception/BundleExtensions.cs 96.66% <90.90%> (-3.34%) ⬇️
...rc/HttpClientInterception/Bundles/BundleFactory.cs 100.00% <100.00%> (ø)
src/HttpClientInterception/Bundles/BundleItem.cs 100.00% <100.00%> (ø)
...pClientInterception/Bundles/BundleItemConverter.cs 100.00% <100.00%> (ø)
...rception/HttpClientInterceptorOptionsExtensions.cs 100.00% <100.00%> (ø)
...eption/HttpRequestInterceptionBuilderExtensions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1e9c6...bf6b9ea. Read the comment docs.

@martincostello martincostello force-pushed the Drop-Newtonsoft-And-Old-TFMs branch from c8a5646 to bf6b9ea Compare May 14, 2022 15:13
@martincostello martincostello mentioned this pull request May 14, 2022
Bump version to 4.0.0 for breaking changes.
- Remove net461.
- Remove net5.0.
- Add net6.0.
Remove dependency on Newtonsoft.Json.
Relates to justeattakeaway#441.
Update NuGet packages to their latest versions.
Add async overload for registering a bundle.
Relates to justeattakeaway#442.
Remove redundant cast needed from when net5.0 was a TFM.
Remove net5.0 from the supported benchmark TFMs.
Remove net461 from supported TFMs.
Add code coverage for parameters being null for RegisterBundleAsync().
Add test case to validate async templating of bundles.
@martincostello martincostello force-pushed the Drop-Newtonsoft-And-Old-TFMs branch from bf6b9ea to f0fb798 Compare November 15, 2022 13:36
@martincostello martincostello marked this pull request as ready for review November 15, 2022 13:38
@martincostello martincostello requested a review from a team as a code owner November 15, 2022 13:38
@martincostello martincostello merged commit 6bf66b0 into justeattakeaway:main Nov 15, 2022
@martincostello martincostello deleted the Drop-Newtonsoft-And-Old-TFMs branch November 15, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement A change that enhances existing functionality or documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async RegisterBundle() overloads Remove Newtonsoft.Json
3 participants