fix multi enumeration bug

[SimonCropp]

No description provided.

[martincostello]

Nice catch. Would you mind adding a unit test for the bug please?

[codecov-commenter]

Codecov Report

Merging #318 (98203d0) into main (0f89fb2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1128      1129    +1     
=========================================
+ Hits          1128      1129    +1     

Flag	Coverage Δ
linux	100.00% <100.00%> (ø)
macos	100.00% <100.00%> (ø)
windows	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/HttpClientInterception/BundleExtensions.cs	100.00% <100.00%> (ø)
...ientInterception/HttpRequestInterceptionBuilder.cs	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f89fb2...98203d0. Read the comment docs.

[SimonCropp]

is there a test that passes multiple items ?

[martincostello]

Doesn't look like it, which I guess is why the bug you've found is there.

The templating tests are here: https://github.com/justeat/httpclient-interception/blob/cbe05bf80a1a06c8086482c04393bc174b958ac2/tests/HttpClientInterception.Tests/Bundles/BundleExtensionsTests.cs#L168-L241

[SimonCropp]

i dont have adequate understanding of this library to produce a test for this bug. but if u have a forward only enumerator (eg from a method that yields), and you have multiple bundle.Items, then BundleItemConverter.FromItem will move the enumerator multiple times. eg if u have 1 templateValues and 2 bundle.Items, then BundleItemConverter.FromItem will only get the 1 templateValues on the first call. the second call to FromItem the enumerator will be empty

[martincostello]

So this is a bug you found purely from reading the code, rather than you trying to do something specific with it and it throwing an exception?

[SimonCropp]

So this is a bug you found purely from reading the code

resharper highlighted it as an error