fix: subtitle download fix & docs update for V4.3 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medanisjbara
changed the title
medanisjbara
changed the title
justchokingaround
requested changes
Jul 27, 2024
|
thank you for your contribution! |
justchokingaround
added a commit
that referenced
this pull request
Aug 4, 2024
* feat: v4.3 * chore: shellcheck * fix: remove slashes from filename (#216) * fix: subtitle download fix & docs update for V4.3 (#218) * fix: update decryption api to lobster-decryption.netlify * fix: download subtitles with -d * doc: update for v4.3 * fix: SC2312 & eval the ffmpeg command * fix: chokerman's suggestions & fix sub var parsing * fix: add labels to mkv downloads and make multiple subs work * choke: remove threads from ffmpeg command --------- Co-authored-by: justchokingaround <ivanonarch@tutanota.com> * chore: merge conflicts * fix: make history function properly and fix player stuff * fix: make windows player work * fix: windows scoop mpv watch_later path * chore: shfmt * chore: shellcheck * docs: update rpc docs --------- Co-authored-by: Med Anis Jbara <74317212+medanisjbara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #136