Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #270

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Develop #270

wants to merge 21 commits into from

Conversation

fOmey
Copy link

@fOmey fOmey commented Jun 2, 2023

Dynamic buffer memory - less greedy buffer memory allocation this time


SD & SD_MMC lib determined by defines.


Malformed packet fix

@justcallmekoko
Copy link
Owner

Just double checking. What hardware have you tested this on. I am going to run through everything I have.

@justcallmekoko
Copy link
Owner

All sniffing for WiFi seems to cause crash on v4, v6, Mini, and Kit. The crash does not occur when sniffing bluetooth. I believe the crash is caused by the memory allocation for the buffer. On the WiFi Dev Board Pro, and LDDB, I get "Failed to allocate buffer memory" but it does not crash. It does however fail to write to the SD card. I do not get this on the official Flipper Zero WiFi Dev Board.

On the CLI, I can see the Marauder successfully open a .pcap file. I am assuming it then fails to write to the buffer as it immediately crashes after opening the file.

Another issue I'm having but I can't figure out why is that when you exit a bluetooth sniff, it crashes. These should not involve the buffer or the SD card.

I think the best way to test this maybe on your end is to get this running on a standard ESP32 Dev Board like a NodeMCU or something. I used the bins generated from your automated workflow.

@justcallmekoko
Copy link
Owner

If needed, maybe just a PR for the SD changes and a separate one to work on the buffer changes. Thoughts?

@fOmey
Copy link
Author

fOmey commented Jun 6, 2023

Just double checking. What hardware have you tested this on. I am going to run through everything I have.

I unfortunately only own ESP32-S3's.

All sniffing for WiFi seems to cause crash on v4, v6, Mini, and Kit. The crash does not occur when sniffing bluetooth. I believe the crash is caused by the memory allocation for the buffer. On the WiFi Dev Board Pro, and LDDB, I get "Failed to allocate buffer memory" but it does not crash. It does however fail to write to the SD card. I do not get this on the official Flipper Zero WiFi Dev Board.

On the CLI, I can see the Marauder successfully open a .pcap file. I am assuming it then fails to write to the buffer as it immediately crashes after opening the file.

Another issue I'm having but I can't figure out why is that when you exit a bluetooth sniff, it crashes. These should not involve the buffer or the SD card.

I think the best way to test this maybe on your end is to get this running on a standard ESP32 Dev Board like a NodeMCU or something. I used the bins generated from your automated workflow.

Failed to allocate memory error is good & fixable, lowering the memory target should fix that.

The crash is a little concerning tho, what chip does the v4, v6 etc. use? ESP32?

Can you test the new workflow when you get a chance.

@fOmey
Copy link
Author

fOmey commented Jun 6, 2023

Created two workflows, one compiled (workflow#16) with 85% memory target.. the latest one (workflow#17) with 75%.

@SomeToms64
Copy link

I tried compiling from source, and the sd connected fine, but this is the issue im getting
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants